forked from CMU-17313Q/cmu-17313q-f24-nodebb-f24-NodeBB
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding automated tests into test/categories to test the search back-end functionality. #59
Open
zanzoonh
wants to merge
21
commits into
f24
Choose a base branch
from
adding-search-tests
base: f24
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the branch to match origin/f24 Merge remote-tracking branch 'origin/adding-search-functionality' into adding-search-functionality
…js to public/src/client/category.js
…gory.js and are found in public/src/client/users.js
…ender post results
…ing the correct thing
…ories/topics as implemented search function is not returning the correct thing
zanzoonh
added
documentation
Improvements or additions to documentation
UserStory2
UserStory1
and removed
UserStory2
labels
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a new branch called "adding-search-tests" to test the front and back-end implementation of the
search functionality.
Added a function into test/categories that calls the search function multiple times with different edge and normal cases and checks if its returning the correct ouput
When running the test files individually: "node test/[file name]", they pass locally, however when running "npm run test" there are errors
This pull request isn't merged into the main branch of the repository as it is failing the npm tests